Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for SecureConversationSecurityTokenParameters class #3904

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Unit Test for SecureConversationSecurityTokenParameters class #3904

merged 5 commits into from
Sep 17, 2019

Conversation

v-fangfc
Copy link
Contributor

Add Unit Test for issue #3864
@StephenBonikowsky, @mconnew, @HongGit

@dnfclas
Copy link

dnfclas commented Sep 12, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@StephenBonikowsky StephenBonikowsky mentioned this pull request Sep 12, 2019
Merged
@v-fangfc
Copy link
Contributor Author

@dotnet-bot please test dotnet-wcf-ci
@dotnet-bot please test dotnet-wcf-ci (Build Linux Debug)

StephenBonikowsky
StephenBonikowsky approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@StephenBonikowsky StephenBonikowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @mconnew can you merge if it looks good to you as well?

@StephenBonikowsky StephenBonikowsky merged commit abbdc21 into dotnet:master Sep 17, 2019
@StephenBonikowsky StephenBonikowsky mentioned this pull request Sep 17, 2019
Closed
@v-fangfc v-fangfc deleted the addTest branch September 18, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mconnew mconnew mconnew left review comments

@StephenBonikowsky StephenBonikowsky StephenBonikowsky approved these changes

@HongGit HongGit Awaiting requested review from HongGit

Assignees

@v-fangfc v-fangfc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-fangfc @dnfclas @mconnew @StephenBonikowsky